Lazy import either 'anyio' or 'trio'#639
Merged
lovelydinosaur merged 4 commits intomasterfrom Dec 12, 2022
Merged
Conversation
Kludex
reviewed
Dec 8, 2022
Contributor
Author
|
@Kludex I'm going with the "yes these need to be separate, because we're being careful and strict about typing". Functionally it would work with a bit of overlap here, but I'd suggest let's keep things neatly separated. |
Kludex
approved these changes
Dec 12, 2022
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Dec 24, 2022
Although anyio is no longer imported unconditionally [1], it's still listed in install_requires in setup.py [2], so I keep python-anyio in depends. [1] encode/httpcore#639 [2] https://github.com/encode/httpcore/blob/0.16.3/setup.py#L59 git-svn-id: file:///srv/repos/svn-community/svn@1365367 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Dec 24, 2022
Although anyio is no longer imported unconditionally [1], it's still listed in install_requires in setup.py [2], so I keep python-anyio in depends. [1] encode/httpcore#639 [2] https://github.com/encode/httpcore/blob/0.16.3/setup.py#L59 git-svn-id: file:///srv/repos/svn-community/svn@1365367 9fca08f4-af9d-4005-b8df-a31f2cc04f65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #626
example.py
Turns out this doesn't fix the #588 conflict, which is still triggered by the usage of
@pytest.mark.anyioin the test suite. 🤷♂️